Skip to content

NMS-19652: Update documentation for trapd config#8411

Merged
Shahbaz-dataq merged 56 commits intofeatures/trapd-config-db-migrationfrom
jira/NMS-19652-trapd-documentation
Apr 7, 2026
Merged

NMS-19652: Update documentation for trapd config#8411
Shahbaz-dataq merged 56 commits intofeatures/trapd-config-db-migrationfrom
jira/NMS-19652-trapd-documentation

Conversation

@Shahbaz-dataq
Copy link
Copy Markdown
Contributor

External References

@github-actions github-actions Bot added the docs label Apr 1, 2026
Base automatically changed from jira/NMS-19621-integrate-trapd-UI-endpoints to features/trapd-config-db-migration April 6, 2026 16:13
@Shahbaz-dataq Shahbaz-dataq marked this pull request as ready for review April 6, 2026 17:44
Copy link
Copy Markdown
Contributor

@synqotik synqotik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one small fix.

= Trapd REST API (v2)
:description: Manage trapd configuration through the OpenNMS REST v2 API.

You can read and update trapd configuration over REST without editing `trapd-configuration.xml` manually.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should change line 5 to just:

You can view and update trapd configuration over REST.

I think we want to downplay that there's even an XML file at all.

Copy link
Copy Markdown
Contributor

@synqotik synqotik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Shahbaz-dataq Shahbaz-dataq requested a review from synqotik April 7, 2026 05:17
@Shahbaz-dataq Shahbaz-dataq merged commit af749fc into features/trapd-config-db-migration Apr 7, 2026
5 checks passed
@Shahbaz-dataq Shahbaz-dataq deleted the jira/NMS-19652-trapd-documentation branch April 7, 2026 05:17
cgorantla added a commit that referenced this pull request Apr 22, 2026
* NMS-19448: Trapd Config to DB: Migrate trapd-configuration.xml to

* NMS-19952: Create initial scaffolding for UI (#8345)

* initial changes

* general configuration ui

* changes

* Changes

* NMS-19597: Create form for SNMP v3 User creation and edit (#8351)

* create user

* fixes

* fixes

* revert changes

* changes

* new changes

* changes

* NMS-19611: Expose rest endpoint for upload/update trapd configuration (#8363)

* upload, get and update rest endpoints

* changes for dto

* test cases

* new rest endpoints or snmp v3 users

* mappers fixes

* field use address from varbind fix

* changes

* new fixes

* new changes

* test cases fix

* test fix

* checkes reverted

* user updates changes

* unused code removed

* menu item

* review changes

* response messages update

* DAO update fix

* NMS-19621: Integrate get/upload/update rest endpoint for trapd config (#8370)

* upload, get and update rest endpoints

* changes for dto

* test cases

* new rest endpoints or snmp v3 users

* mappers fixes

* field use address from varbind fix

* Trapd UI rest endpoint integration

* new changes

* new changes

* changes

* changes

* changes

* change

* search changes

* changes

* new fixes

* new changes

* test cases fix

* test fix

* api changes

* checkes reverted

* new changes for fe

* changes

* test coverage

* user updates changes

* scv changes and test coverage

* unused code removed

* menu item

* route fix

* test fixes

* naming fixes

* unused imports

* review changes

* response messages update

* validator fix

* DAO update fix

* DAO fixes

* changelog

* New changes and test fixes

* new fixes

* test fix

* NMS-19652: Update documentation for trapd config (#8411)

* upload, get and update rest endpoints

* changes for dto

* test cases

* new rest endpoints or snmp v3 users

* mappers fixes

* field use address from varbind fix

* Trapd UI rest endpoint integration

* new changes

* new changes

* changes

* changes

* changes

* change

* search changes

* changes

* new fixes

* new changes

* test cases fix

* test fix

* api changes

* checkes reverted

* new changes for fe

* changes

* test coverage

* user updates changes

* scv changes and test coverage

* unused code removed

* menu item

* route fix

* test fixes

* naming fixes

* unused imports

* review changes

* trapd documentation

* response messages update

* validator fix

* DAO update fix

* config dao fix

* DAO fixes

* changelog

* changes

* menu code revert

* review comment

* NMS-19128: Removing trapd-configuration.xml from ConfigTester

* NMS-19128: Fix few issues with UI integration

fix SHA2** are getting rejected
remove general config and note
Allow snmp-trap-address to be optional

* NMS-19128: Restrict access to admin/provision roles

* NMS-19125: Fix reload daemon for trapd

* NMS-19128: Few more validations

* NMS-19128: remove unused imports and fix spelling

* NMS-19128: Move trapdConfigDao to application context dao

This will allow users to disable trapd

* NMS-19218: Explicitly disable UsmUserTable logging

This will prevent leaking of user authentication details

* NMS-19128: passphrases need to be at least 8 characters

---------

Co-authored-by: Shahbaz Masood <159028986+Shahbaz-dataq@users.noreply.github.com>
Co-authored-by: Shahbaz <rmasood@nanthealth.com>
Co-authored-by: Chandra Gorantla <chandra@opennms.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants